-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the ELK imports break the dev playground, drop them #6055
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6055 +/- ##
=======================================
Coverage 4.49% 4.49%
=======================================
Files 383 383
Lines 53925 53925
Branches 596 596
=======================================
Hits 2425 2425
Misses 51500 51500
Flags with carried forward coverage won't be shown. Click here to find out more. |
f135a3a <-- original commit introducing bug is ?? |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@sidharthv96 ^^ can you take this please in reference to your previous commit. f135a3a |
📑 Summary
dev playground dies looking for these imports
Resolves #
📏 Design Decisions
don't import the broken thing tha
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.