Adding POC for a client options configurer. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsal
approved these changes
Nov 1, 2024
| .build(); | ||
| return new ClientOptions(environment, headers, headerSuppliers, okhttpClient); | ||
| OkHttpClient.Builder okHttpClientBuilder = new OkHttpClient.Builder() | ||
| .addInterceptor(new RetryInterceptor(3)); |
There was a problem hiding this comment.
Shouldn't it be configurable as well in case I want to implement my own retry logic? And this one as a default retry mechanism that can be replaced if needed
There was a problem hiding this comment.
In theory you could add a new interceptor that handles retry in your way, but I'm not sure if you could clear any existing interceptors already, but you might be able to if this got merged.
Don't hold your breath though @bitsal, there's been no movement on this PR or acknowledgement of this from the merge team since I've raised the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been facing an error with a passthrough request where the response headers are too big for the HTTP client.
Can we add a means to allow configuring the underlying HTTP client, just so that we can supply a few tweaks to make it work for this request?