Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Custom Themes "overhaul" #211

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Custom Themes "overhaul" #211

wants to merge 8 commits into from

Conversation

Bloctans
Copy link
Member

@Bloctans Bloctans commented Jan 29, 2024

Changes:

  • Edited custom themes v1 to no longer care about orangedark and orangelight.
  • More detailed reset button, also added reset to saved theme

@Bloctans Bloctans changed the title (1.9) Custom Themes v (1.9) Custom Themes overhaul Jan 29, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7078df9
Status: ✅  Deploy successful!
Preview URL: https://ad3e2dd0.meower-svelte.pages.dev
Branch Preview URL: https://custom-themes-v2.meower-svelte.pages.dev

View logs

Copy link
Member

@showierdata9978 showierdata9978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foregroundOrange should probably be renamed to secondary

@showierdata9978 showierdata9978 self-requested a review January 30, 2024 03:21
Copy link
Member

@showierdata9978 showierdata9978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foregroundOrange should probably be renamed to secondary

@tnix100
Copy link
Member

tnix100 commented Jan 30, 2024

This should not happen. v1 already supports not including orangeLight and orangeDark. If you want to make it simpler, orangeLight and orangeDark should not be included by default in the theme JSON.

@tnix100
Copy link
Member

tnix100 commented Jan 30, 2024

I like the idea of the reset buttons though.

@showierdata9978
Copy link
Member

they should just be simplified, instead of teh orange stuff, use terms like primary, secondary, etc

@Bloctans
Copy link
Member Author

Bloctans commented Feb 3, 2024

This should not happen. v1 already supports not including orangeLight and orangeDark. If you want to make it simpler, orangeLight and orangeDark should not be included by default in the theme JSON.

so do i scrap v2 and just edit v1 to not care about orangelight and dark?

@tnix100
Copy link
Member

tnix100 commented Feb 3, 2024

This should not happen. v1 already supports not including orangeLight and orangeDark. If you want to make it simpler, orangeLight and orangeDark should not be included by default in the theme JSON.

so do i scrap v2 and just edit v1 to not care about orangelight and dark?

v1 already doesn't care about orangeLight and orangeDark. But yes, you should scrap v2, it's a pointless change.

@showierdata9978
Copy link
Member

another PR is using v2 rn too.

@Bloctans Bloctans changed the title (1.9) Custom Themes overhaul (1.9) Custom Themes "overhaul" Feb 4, 2024
@Bloctans Bloctans requested a review from tnix100 February 4, 2024 06:42
@Bloctans Bloctans added this to the Svelte 1.9!!!!! milestone Feb 12, 2024
@williamhorning williamhorning changed the title (1.9) Custom Themes "overhaul" Custom Themes "overhaul" Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants