feat: add skip-images flag feature #74
Conversation
|
Merging these commits will result in the following changelog entries: Changelogsapp-update-module (master)New changes in app-update-module since master: Features
|
This commit is adding the skip-images flag to the app-gen script, allowing the artifact creation to ignore image inclusion. The app script will hand over the responsibility of pulling images to the orchestrator. Changelog: Added support for skipping image inclusion in artifact. Ticket: None Signed-off-by: DamKas <[email protected]>
|
@merlin-northern Do you want to have a look at this? |
There was a problem hiding this comment.
Hello @DamKast and thank you for your contribution. As @merlin-northern is already busy with other contributions, I will be reviewing your work 😃
By design, we want this update module to not pull images, but the module actually will pull an image needed by the manifest if it is not found in the Artifact.
We can have the feature that you want to add, so that it can be used for testing or on devices where network is fully reliable, but we should do it in a backwards compatible way, piggybacking on the behavior that I just described.
Your current proposed changes are conditionally generating (and then decompressing) images.tar.gz file in the Artifact. In other words, you have both modified the generator and the update module so the the file is added or not and expected or not. But it should be possible to do it simpler by creating a dummy/empty images.tar.gz in the generator, and then the module should not require much changes, it will decompress an empty file, not load any image, and then just start the composition (which will indirectly pull the images).
Can you rework the PR to get something similar to that?
Description
It would be very usefull having the possibility to skip including images. That means give to docker compose the responsibility to pull the required images through the network directly from the target device.
This fix modifies the metadata:
If the skip-images flag is set, the metadata will include
images_urlsbut not theimagesshas.When the artifact is installed on the target, the app script will look for the
images.tar.gzfile but since it is not included in the artifact, it will not load any image.The
images_urlsis used for the clean_up function.https://hub.mender.io/t/suggestion-add-a-skip-images-option-to-app-update-module/7268