-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial support for Composite Foreign Keys and Indexes #19
Open
Trellian
wants to merge
9
commits into
memtrip:master
Choose a base branch
from
Trellian:feature/composite_indexes_fks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b952cba
Added initial support for Composite Foreign Keys and Indexes
Trellian 0bfb271
Added initial support for Composite Foreign Keys and Indexes, Table C…
Trellian 802006c
Merge branch 'feature/composite_indexes_fks' of https://github.com/Tr…
Trellian c614d7b
Fixed whitespace error on creation of indexes;
Trellian a5370cd
Added better, clearer support for Table-level and Column-level annota…
Trellian 36034d1
Updated README documentation for Table-level and Column level Annotat…
Trellian 959d404
More amendments to README, and small changes to Trigger Annotations
Trellian 991e4d3
Re-enabled the PrimaryKey validation code.
Trellian d918648
Relaxed support for table alias names not yet fully implemented, Fore…
Trellian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,5 @@ preprocessor/target | |
common/target | ||
build | ||
*.keystore | ||
*.~* | ||
projectBackupFiles |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,30 +23,39 @@ | |
|
||
/** | ||
* @author Samuel Kirton [[email protected]] | ||
* @author Adrian Velcich [[email protected]] | ||
* | ||
*/ | ||
public class SQLOpen extends SQLiteOpenHelper { | ||
private SQLiteDatabase mDatabase; | ||
private String[] mSchemaArray; | ||
private String[] mTableNameArray; | ||
private String[] mCreateIndexQuery; | ||
private List<String> mIndexNames; | ||
|
||
private String[] mCreateIndexStatements; | ||
private List<String> mIndexNames; | ||
private String[] mCreateTriggerStatements; | ||
private List<String> mTriggerNames; | ||
|
||
protected SQLiteDatabase getDatabase() { | ||
return mDatabase; | ||
} | ||
|
||
protected SQLOpen(String name, int version, String[] schemaArray, | ||
String[] tableNameArray, | ||
String[] indexQuery, | ||
String[] createIndexStatements, | ||
List<String> indexNames, | ||
String[] createTriggerStatements, | ||
List<String> triggerNames, | ||
Context context) { | ||
|
||
super(context, name, null, version); | ||
|
||
mSchemaArray = schemaArray; | ||
mTableNameArray = tableNameArray; | ||
mCreateIndexQuery = indexQuery; | ||
mIndexNames = indexNames; | ||
mCreateIndexStatements = createIndexStatements; | ||
mIndexNames = indexNames; | ||
mCreateTriggerStatements = createTriggerStatements; | ||
mTriggerNames = triggerNames; | ||
|
||
mDatabase = getWritableDatabase(); | ||
} | ||
|
||
|
@@ -57,11 +66,17 @@ public void onCreate(SQLiteDatabase db) { | |
db.execSQL(schema); | ||
} | ||
|
||
for (String createIndex : mCreateIndexQuery) { | ||
if (createIndex != null) { | ||
db.execSQL(createIndex); | ||
} | ||
} | ||
for (String createIndex : mCreateIndexStatements) { | ||
if (createIndex != null) { | ||
db.execSQL(createIndex); | ||
} | ||
} | ||
|
||
for (String createTrigger : mCreateTriggerStatements) { | ||
if (createTrigger != null) { | ||
db.execSQL(createTrigger); | ||
} | ||
} | ||
} | ||
|
||
@Override | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
client/src/tests/java/com/memtrip/sqlking/integration/ForeignKeyTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
/** | ||
* Copyright 2013-present memtrip LTD. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.memtrip.sqlking.integration; | ||
|
||
import android.database.Cursor; | ||
|
||
import com.memtrip.sqlking.operation.function.Raw; | ||
|
||
import org.junit.Before; | ||
import org.junit.Test; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
/** | ||
* @author Adrian Velcich [[email protected]] | ||
*/ | ||
public class ForeignKeyTest extends IntegrationTest | ||
{ | ||
@Before | ||
public void setUp() | ||
{ | ||
super.setUp(); | ||
|
||
getSetupData().tearDownTestData(getSQLProvider()); | ||
getSetupData().setupTestData(getSQLProvider()); | ||
|
||
getSetupLog().tearDownTestLogs(getSQLProvider()); | ||
getSetupLog().setupTestLogs(getSQLProvider()); | ||
} | ||
|
||
@Test | ||
public void testUserForeignKeyIsCreated() | ||
{ | ||
Cursor cursor = Raw.getBuilder() | ||
.query("PRAGMA foreign_key_list('User');") | ||
.execute(getSQLProvider()); | ||
|
||
List<String> foreignKeys = getForeignKeys(cursor); | ||
|
||
assertEquals(1, foreignKeys.size()); | ||
} | ||
|
||
private List<String> getForeignKeys(Cursor cursor) | ||
{ | ||
List<String> foreignKeys = new ArrayList<>(); | ||
|
||
try { | ||
while (cursor.moveToNext()) | ||
{ | ||
int foreignKey = cursor.getColumnIndex("name"); | ||
|
||
if (foreignKey != -1) | ||
{ | ||
String foreignKeyName = cursor.getString(foreignKey); | ||
foreignKeys.add(foreignKeyName); | ||
} | ||
} | ||
} | ||
finally | ||
{ | ||
cursor.close(); | ||
} | ||
|
||
return foreignKeys; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the cast to Object[] required?