Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it look more like the Telegram desktop app #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

joeytwiddle
Copy link

@joeytwiddle joeytwiddle commented Jul 18, 2019

I changed the layout and colours in light-mode to make the Telegram in Franz look more like the Telegram desktop app. It's still not an exact clone, but it's closer!

I then did the same for dark-mode, based on magazov's branch.

Some things still TODO:

  • Some of the pop up windows are unfinished, although they are usable. E.g. the Forward message dialogue window, and windows accessible from the burger menu
  • I overrode a lot of @magazov's black backgrounds with the dark blue of the Telegram desktop. We should probably do this directly in magazov's code instead of overriding.
  • When selecting a message in dark mode, it doesn't get highlighted. Also the "check" icon appears off.
  • Use 2 spaces for indentation.
  • Often instead of !important we could have made the selector more specific e.g. by putting body in front. But that won't always work.
    (The issue here is that sometimes our CSS appears in the DOM before Telegram's CSS, and sometimes after. This behaviour appears to be inconsistent. If we cannot consistently load our stylesheet after Telegram's, then we need to take extra measures to override their CSS rules.)

Current Telegram in Franz
Telegram in Franz (this branch)
Telegram desktop app
Telegram in Franz (this branch)
Telegram desktop app

This PR will close https://github.com/meetfranz/franz/issues/1240

@joeytwiddle joeytwiddle force-pushed the beautify branch 15 times, most recently from e0ae0be to 10b55fe Compare July 23, 2019 05:08
@joeytwiddle joeytwiddle force-pushed the beautify branch 6 times, most recently from c51e262 to 48d21db Compare July 24, 2019 10:44
@Stanzilla
Copy link

Your screenshots are a bit broken

@joeytwiddle
Copy link
Author

Sorry, they are intentionally like that. I wanted to anonymise them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme for telegram
3 participants