-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it look more like the Telegram desktop app #13
Open
joeytwiddle
wants to merge
13
commits into
meetfranz:master
Choose a base branch
from
joeytwiddle:beautify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeytwiddle
force-pushed
the
beautify
branch
15 times, most recently
from
July 23, 2019 05:08
e0ae0be
to
10b55fe
Compare
joeytwiddle
force-pushed
the
beautify
branch
6 times, most recently
from
July 24, 2019 10:44
c51e262
to
48d21db
Compare
Your screenshots are a bit broken |
Sorry, they are intentionally like that. I wanted to anonymise them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the layout and colours in light-mode to make the Telegram in Franz look more like the Telegram desktop app. It's still not an exact clone, but it's closer!
I then did the same for dark-mode, based on magazov's branch.
Some things still TODO:
!important
we could have made the selector more specific e.g. by puttingbody
in front. But that won't always work.(The issue here is that sometimes our CSS appears in the DOM before Telegram's CSS, and sometimes after. This behaviour appears to be inconsistent. If we cannot consistently load our stylesheet after Telegram's, then we need to take extra measures to override their CSS rules.)
Current Telegram in Franz
Telegram in Franz (this branch)
Telegram desktop app
Telegram in Franz (this branch)
Telegram desktop app
This PR will close https://github.com/meetfranz/franz/issues/1240