Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: payment provider ID detection #335

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix: payment provider ID detection #335

merged 3 commits into from
Jun 10, 2024

Conversation

shahednasser
Copy link
Member

  • Change payment provider ID switch cases to check if a provider ID starts with a value. That's because the last part of the provider ID is configurable by the developer in the Medusa config, so it may be different than what we expect.
  • Fix stripe's provider ID to start with pp_stripe_

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-starter-medusa ❌ Failed (Inspect) Jun 10, 2024 1:45pm
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 1:45pm

@shahednasser shahednasser requested a review from sradevski June 10, 2024 13:47
@shahednasser shahednasser merged commit 179a245 into v2 Jun 10, 2024
3 of 5 checks passed
@shahednasser shahednasser deleted the fix/stripe_id branch June 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahednasser @sradevski