Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve price type #334

Merged
merged 5 commits into from
Jun 6, 2024
Merged

fix: retrieve price type #334

merged 5 commits into from
Jun 6, 2024

Conversation

shahednasser
Copy link
Member

No description provided.

@shahednasser shahednasser requested a review from sradevski June 6, 2024 12:33
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-starter-medusa ❌ Failed (Inspect) Jun 6, 2024 2:15pm
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 2:15pm

@sradevski
Copy link
Member

@shahednasser it seems the build is failing, can you just check that first please?

@shahednasser
Copy link
Member Author

@sradevski seems like the latest changes in the http types have messed up a lot of things. I've tried resolving these type errors with what made sense to me, but as I'm not very familiar with this project would be great if you gave these changes a good look

@sradevski
Copy link
Member

Looks good 👍

@shahednasser
Copy link
Member Author

@sradevski Any idea why the test fails with [Error]: Fields [+category_children] are not valid? I can't reproduce it

@sradevski
Copy link
Member

@shahednasser please ignore the tests for now, as long as storefront-v2-staging is passing we're good. We'll get to the tests once the API stabilizes a bit more

@shahednasser
Copy link
Member Author

@sradevski ah ok got it, I'll get the PR in then 👍🏻

@shahednasser shahednasser merged commit 3b5eeaa into v2 Jun 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants