Add french trad in i18n translations #9885

aurelien-f · 2024-10-31T19:26:51Z

Hello, i send you a new pull request.

What - Add french trad in i18n translations
Why - Offer a new language and be able to offer my clients a French language
How - I used AI and my knowledge of French to do the translation
Testing - I have not tested the changes.

changeset-bot · 2024-10-31T19:26:56Z

⚠️ No Changeset found

Latest commit: 4a576f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-31T19:26:58Z

@aurelien-f is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

triplecasquette · 2024-11-01T03:19:45Z

I can help here I'm french, and I'm looking for Dashboard translation :)

aurelien-f · 2024-11-01T06:21:59Z

I can help here I'm french, and I'm looking for Dashboard translation :)

Thanks, i translated all the document but if you want to check or correct some parts.

Can i add you on discord ?

gmonarque · 2024-11-01T10:50:26Z

Hello @aurelien-f, I already did a PR adressin this feature: #9677
I used an automated tool to translate so I think your translation should be of better quality
I think you need to updates some configuration files to include a new lang
Maybe push your translation to my branch & I'll update my PR to avoid a duplicate on here?
Salutations!

triplecasquette · 2024-11-01T13:21:37Z

I can help here I'm french, and I'm looking for Dashboard translation :)

Thanks, i translated all the document but if you want to check or correct some parts.

Can i add you on discord ?

Yes no problem

kasperkristensen

Hi @aurelien-f

Thanks for the PR, the fr.json file is missing some keys and has an unexpected key as well:

Validation failed for fr.json:
  Missing required key: "edit" at /products
  Unexpected key: "editProduct" at /products

You will also need to update this file: https://github.com/medusajs/medusa/blob/develop/packages/admin/dashboard/src/i18n/languages.ts to include French as an option.

And export the fr.json file from here: https://github.com/medusajs/medusa/blob/develop/packages/admin/dashboard/src/i18n/translations/index.ts

triplecasquette · 2024-11-06T13:37:30Z

Hi @aurelien-f

Thanks for the PR, the fr.json file is missing some keys and has an unexpected key as well:
Validation failed for fr.json:
  Missing required key: "edit" at /products
  Unexpected key: "editProduct" at /products
You will also need to update this file: https://github.com/medusajs/medusa/blob/develop/packages/admin/dashboard/src/i18n/languages.ts to include French as an option.

And export the fr.json file from here: https://github.com/medusajs/medusa/blob/develop/packages/admin/dashboard/src/i18n/translations/index.ts

I tried to complete these missing steps but it seems I cannot commit into this PR What should I do?

adrien2p

Thank you very much for the contribution 💪
I ve made a few suggestions, could you have a look and let me know what you think about them please? Also, depending on what you think, they are also likely applicable to the rest of the translations 😃

adrien2p · 2024-11-06T13:31:01Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"items_one": "{{count}} item",
+		"items_other": "{{count}} items",
+		"countSelected": "{{count}} sélectionné",
+		"countOfTotalSelected": "{{count}} de {{total}} sélectionné",


Suggested change

"countOfTotalSelected": "{{count}} de {{total}} sélectionné",

"countOfTotalSelected": "{{count}} sur {{total}} sélectionné",

adrien2p · 2024-11-06T13:31:18Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"new": "Nouveau",
+		"modified": "Modifié",
+		"added": "Ajouté",
+		"removed": "Removed",


Suggested change

"removed": "Removed",

"removed": "supprimé",

I would suggest adding An uppercase

Supprimé

adrien2p · 2024-11-06T13:33:48Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"noSearchResults": "Aucun résultat de recherche",
+		"noSearchResultsFor": "Aucun résultat de recherche pour <0>'{{query}}'</0>",
+		"noRecordsTitle": "Aucun enregistrement",
+		"noRecordsMessage": "Il n'y a pas d'enregistrements à afficher",


Suggested change

"noRecordsMessage": "Il n'y a pas d'enregistrements à afficher",

"noRecordsMessage": "Il n'y a pas d'enregistrement à afficher",

for consistency with previous singular usage

adrien2p · 2024-11-06T13:36:05Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"noRecordsMessage": "Il n'y a pas d'enregistrements à afficher",
+		"unsavedChangesTitle": "Êtes-vous sûr de vouloir quitter ce formulaire ?",
+		"unsavedChangesDescription": "Vous avez des modifications non enregistrées qui seront perdues si vous quittez ce formulaire.",
+		"includesTaxTooltip": "Les prix de cette colonne sont taxés inclus.",


Suggested change

"includesTaxTooltip": "Les prix de cette colonne sont taxés inclus.",

"includesTaxTooltip": "Les prix de cette colonne sont taxes incluses.",

I would say taxes incluses instead of taxés inclus which is probably a typo no?

Maybe a better translation would be :

Les prix de cette colonne incluent les taxes
or
Les prix de cette colonne sont TTC (toutes taxes comprises)

What you think ?

I like both suggestions 👍 I would prefer the first one but I let you decide

I like both suggestions 👍 I would prefer the first one but I let you decide

I prefer the second one. Think it's more accurate but maybe not what's expected.
I Would suggest going with the first one and waiting for more opinions on the subject ^^

adrien2p · 2024-11-06T13:37:29Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"unsavedChangesTitle": "Êtes-vous sûr de vouloir quitter ce formulaire ?",
+		"unsavedChangesDescription": "Vous avez des modifications non enregistrées qui seront perdues si vous quittez ce formulaire.",
+		"includesTaxTooltip": "Les prix de cette colonne sont taxés inclus.",
+		"excludesTaxTooltip": "Les prix de cette colonne sont taxés exclusifs.",


Suggested change

"excludesTaxTooltip": "Les prix de cette colonne sont taxés exclusifs.",

"excludesTaxTooltip": "Les prix de cette colonne sont taxes exclues.",

Maybe a better translation would be :

Les prix de cette colonne excluent les taxes
or
Les prix de cette colonne sont HT (Hors Taxes)

What you think ?

Depends on the previous comment discussion

adrien2p · 2024-11-06T13:45:50Z

packages/admin/dashboard/src/i18n/translations/fr.json

+				"storeSettings": "Paramètres de la boutique"
+			},
+			"settings": {
+				"header": "Settings",


Suggested change

"header": "Settings",

"header": "Paramètres",

adrien2p · 2024-11-06T13:46:05Z

packages/admin/dashboard/src/i18n/translations/fr.json

+	},
+	"dataGrid": {
+		"columns": {
+			"view": "View",


Suggested change

"view": "View",

"view": "Vue",

wdyt?

Depending on the context maybe "Affichage" is more suitable

Oh yeah, that seems better indeed 💪

adrien2p · 2024-11-06T13:48:07Z

packages/admin/dashboard/src/i18n/translations/fr.json

+			}
+		},
+		"errors": {
+			"fixError": "Fix error",


Suggested change

"fixError": "Fix error",

"fixError": "Corriger les erreurs",

wdyt?

Seems singular here so I would say :

Corriger l'erreur

adrien2p · 2024-11-06T13:52:51Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		}
+	},
+	"sales_channels": {
+		"availableIn": "Disponible dans <0>{{x}}</0> de <1>{{y}}</1> canaux de vente"


Suggested change

"availableIn": "Disponible dans <0>{{x}}</0> de <1>{{y}}</1> canaux de vente"

"availableIn": "Disponible dans <0>{{x}}</0> canaux de vente sur <1>{{y}}</1>"

Wouldnt this be more accurate?

adrien2p · 2024-11-06T13:53:03Z

packages/admin/dashboard/src/i18n/translations/fr.json

+		"availableIn": "Disponible dans <0>{{x}}</0> de <1>{{y}}</1> canaux de vente"
+	},
+	"products": {
+		"domain": "Products",


Suggested change

"domain": "Products",

"domain": "Produits",

Add french trad in i18n translations

a1a2bae

aurelien-f requested a review from a team as a code owner October 31, 2024 19:26

aurelien-f requested review from sgirones, riqwan and carlos-r-l-rodrigues October 31, 2024 19:26

Merge branch 'develop' into french-trad

4a576f8

kasperkristensen requested changes Nov 6, 2024

View reviewed changes

kasperkristensen mentioned this pull request Nov 6, 2024

feat(dashboard, translations): add french translation #9677

Closed

adrien2p reviewed Nov 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add french trad in i18n translations #9885

Add french trad in i18n translations #9885

aurelien-f commented Oct 31, 2024

changeset-bot bot commented Oct 31, 2024 •

edited

Loading

vercel bot commented Oct 31, 2024

triplecasquette commented Nov 1, 2024

aurelien-f commented Nov 1, 2024 •

edited

Loading

gmonarque commented Nov 1, 2024

triplecasquette commented Nov 1, 2024

kasperkristensen left a comment •

edited

Loading

triplecasquette commented Nov 6, 2024 •

edited

Loading

adrien2p left a comment

adrien2p Nov 6, 2024

adrien2p Nov 6, 2024

triplecasquette Nov 6, 2024

adrien2p Nov 6, 2024

adrien2p Nov 6, 2024

triplecasquette Nov 6, 2024

adrien2p Nov 7, 2024

triplecasquette Nov 7, 2024

adrien2p Nov 6, 2024

triplecasquette Nov 6, 2024 •

edited

Loading

adrien2p Nov 7, 2024

adrien2p Nov 6, 2024

adrien2p Nov 6, 2024

triplecasquette Nov 6, 2024

adrien2p Nov 7, 2024

adrien2p Nov 6, 2024

triplecasquette Nov 6, 2024

adrien2p Nov 6, 2024

adrien2p Nov 6, 2024

	"countOfTotalSelected": "{{count}} de {{total}} sélectionné",
	"countOfTotalSelected": "{{count}} sur {{total}} sélectionné",

	"noRecordsMessage": "Il n'y a pas d'enregistrements à afficher",
	"noRecordsMessage": "Il n'y a pas d'enregistrement à afficher",

	"includesTaxTooltip": "Les prix de cette colonne sont taxés inclus.",
	"includesTaxTooltip": "Les prix de cette colonne sont taxes incluses.",

	"excludesTaxTooltip": "Les prix de cette colonne sont taxés exclusifs.",
	"excludesTaxTooltip": "Les prix de cette colonne sont taxes exclues.",

	"availableIn": "Disponible dans <0>{{x}}</0> de <1>{{y}}</1> canaux de vente"
	"availableIn": "Disponible dans <0>{{x}}</0> canaux de vente sur <1>{{y}}</1>"

Add french trad in i18n translations #9885

Are you sure you want to change the base?

Add french trad in i18n translations #9885

Conversation

aurelien-f commented Oct 31, 2024

changeset-bot bot commented Oct 31, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Oct 31, 2024

triplecasquette commented Nov 1, 2024

aurelien-f commented Nov 1, 2024 • edited Loading

gmonarque commented Nov 1, 2024

triplecasquette commented Nov 1, 2024

kasperkristensen left a comment • edited Loading

Choose a reason for hiding this comment

triplecasquette commented Nov 6, 2024 • edited Loading

adrien2p left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triplecasquette Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 31, 2024 •

edited

Loading

aurelien-f commented Nov 1, 2024 •

edited

Loading

kasperkristensen left a comment •

edited

Loading

triplecasquette commented Nov 6, 2024 •

edited

Loading

triplecasquette Nov 6, 2024 •

edited

Loading