Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orders): fixs date comparison when using different locale #10033

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from

Conversation

ylyra
Copy link

@ylyra ylyra commented Nov 11, 2024

This PR fixs the inline if for date filter in the orders page when the admin is in a different locale

How it is currently:
image

How it should be in every locale:
image

(in my examples, I'm using the pt-BR locale)

@ylyra ylyra requested a review from a team as a code owner November 11, 2024 20:09
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: eb9a73c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

@ylyra is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant