Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1): Store session request for concurrent fetches #2

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

dianabarsan
Copy link
Member

#1

Copy link

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One small suggestion inline, but this is great, thanks.

src/index.js Outdated Show resolved Hide resolved
]);
expect(fetch.args[4]).to.deep.equal([
'randomUrl4',
{ headers: new Headers({ 'Cookie': 'AuthSession=theonetruesession' }) }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be only one!

@dianabarsan dianabarsan merged commit d52bfcc into main Feb 13, 2024
4 checks passed
@dianabarsan dianabarsan deleted the store-session-request branch February 13, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants