Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #1

wants to merge 1 commit into from

Conversation

CescaGarrett
Copy link
Contributor

  • Update header image to reflect available icons
  • Revise copy for clarity
  • Add additional image with icon examples

* Update header image to reflect available icons
* Revise copy for clarity
* Add additional image with icon examples
@CescaGarrett CescaGarrett requested a review from SCdF October 23, 2019 19:21

The design team has put together a resource to help with best practices when selecting and using icons in configuration. Check out the [best practices](https://docs.google.com/document/d/1vWTL9RCnMK-_jFVbQeIlIZIkfyw4DVTO-lxu6vCHieo/edit#heading=h.wlx8vh5tj0p4) to learn more about which icons can be used for which use cases and workflows.
NOTE: We recommend using SVG icons within your health app due to their smaller size. Additionally, if you are using medic-conf to upload resources, make sure you add the correct icons for people and places to your `resources.json` file. Otherwise, uploading resources will inadvertently remove your people and place icons. An issue is being raised in medic-conf to solve this. You'll need to define `medic-clinic`, `medic-health-center`, `medic-district-hospital` and `medic-person` in your `resources.json` and set them to the appropriate SVG files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derickl Do you know if the issue mentioned here was resolved, and if this language is still accurate?

Copy link

@SCdF SCdF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna say that this should be closed, given its age :-)

(At the time I help off reviewing it awaiting a response to the question raised in the comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants