Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address sonarlint issues #151

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: address sonarlint issues #151

merged 2 commits into from
Nov 25, 2024

Conversation

njuguna-n
Copy link

Description

Fix sonar lint issues

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n requested a review from lorerod November 18, 2024 10:02
@njuguna-n njuguna-n marked this pull request as ready for review November 18, 2024 10:02
lorerod
lorerod approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuguna-n

@njuguna-n njuguna-n merged commit c9354ff into openmrs-mediator Nov 25, 2024
3 checks passed
@njuguna-n njuguna-n deleted the openmrs-mediator-fix-sonarlint branch November 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

Assignees

@njuguna-n njuguna-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njuguna-n @lorerod @njogz