Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#142): adding tests to increase coverage #143

Merged
merged 3 commits into from
Oct 23, 2024
Merged

chore(#142): adding tests to increase coverage #143

merged 3 commits into from
Oct 23, 2024

Conversation

witash
Copy link
Contributor

@witash witash commented Oct 18, 2024

closes #142

@witash witash requested a review from lorerod October 18, 2024 12:24
lorerod
lorerod approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @witash! This looks great to me! I’ve added a couple of suggestions for improvement, but there are no blockers.

mediator/src/controllers/tests/cht.spec.ts Show resolved Hide resolved
mediator/src/utils/tests/cht.spec.ts Show resolved Hide resolved
mediator/src/utils/tests/cht.spec.ts Show resolved Hide resolved
mediator/src/utils/tests/fhir.spec.ts Show resolved Hide resolved
mediator/src/utils/tests/openmrs_sync.spec.ts Show resolved Hide resolved
@witash witash merged commit 7d279c1 into openmrs-mediator Oct 23, 2024
3 of 5 checks passed
@witash witash deleted the 142-unit-tests branch October 23, 2024 10:32
@andrablaj andrablaj mentioned this pull request Oct 23, 2024
Closed
29 tasks
@witash witash restored the 142-unit-tests branch October 28, 2024 09:35
@witash
Copy link
Contributor Author

witash commented Oct 28, 2024

@lorerod didn't see your comments before merging, but the changes are here e3f1a4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witash @lorerod