chore(#9534): upgrade PouchDB to version 9 #9550
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latin-panda
changed the title
garethbowen
reviewed
Oct 16, 2024
latin-panda
commented
Oct 17, 2024
| @@ -234,8 +234,14 @@ describe('Db Service', () => { | |||
| }); | |||
|
|
|||
| describe('method wrapping', () => { | |||
| let testDB; | |||
| let syncTarget; | |||
|
|
|||
| beforeEach(() => { | |||
| window.PouchDB = require('pouchdb-browser').default; | |||
There was a problem hiding this comment.
All these functions from L251 (bulkGet, get, allDocs, etc) aren't located in window.PouchDB.prototype. The PouchInternal's constructor calls _setup() to add all those functions to a DB instance.
To make these tests work, we create an instance and make window.PouchDB return it, so later we stub its functions.
latin-panda
commented
Oct 17, 2024
latin-panda
commented
Oct 17, 2024
tests/scalability/replicate-real-world-docs/add-docs-to-remote.js
Outdated
Show resolved
Hide resolved
dianabarsan
reviewed
Oct 17, 2024
tests/scalability/replicate-real-world-docs/add-docs-to-remote.js
Outdated
Show resolved
Hide resolved
| await target.bulkDocs([{ _id: uuidv4() }]); | ||
| sinon.stub(target, 'allDocs').rejects({ status: 400, name: 'forbidden' }); | ||
| await syncTarget.bulkDocs([{ _id: uuidv4() }]); | ||
| sinon.stub(syncTarget, 'bulkGet').rejects({ status: 400, name: 'forbidden' }); |
There was a problem hiding this comment.
Hm, did the internal sync implementation change?
There was a problem hiding this comment.
I tried to check the sync implementation (node-modules) because it wasn't breaking with rejection from allDocs, but bulkGet breaks it. I need to research more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work won't be continued. I'm leaving the PR open for now, as it might be easier to find and serve as a reference.
#9534
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.