Remove custom today XPath function #7821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes our custom
today
XPath function (allowing us to inherit the default functionality from the OpenRosatoday
function. The difference is that our custom implementation oftoday
would include the current time value while OpenRosa's default implementation (which matches JavaRosa) is thattoday
only returns today's date at midnight in the current timezone.Form changes:
In places where we were using
today
, If we do not actually care about the time value, I just let it be. If it seemed like the time value might be relevant, I switched to usenow
. When today was being wrapped with afloor
call, I just removed thefloor
since it should no longer be necessary (see the discussion on the issue for more details about this). Finally, I also tried to remove unnecessary calls todecimal-date-time
as I went. We were using these a lot when comparing date values, but this is unnecessary. (Enketo supports comparing date values with<>=
. They do not have to be converted to numbers.)Closes #7731
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.