feat(#373): merge-contacts action

[kennsippell]

Description

#373

This adds new action cht merge-contacts. The change proposes to:

• Move the code for move-contacts into a library lib/hierarchy-operations with interfaces move and merge
• Parameterize the move-contacts code changing logic for: input validation, deletes the top-level contact, changes how lineages are updated, and adds report reassignment. All else remains unaltered.

Handles reports and contacts only. Unclear what other doc types I should be worried about.

Things I still need to do. Thinking to do them in their own PRs.

• Add an option which deletes the primary contact so resulting areas don't have two duplicates contacts Ability to recurively delete a place in CHT hierarchy #650
• Update upload-docs so it handles user accounts when deleting a document Merge-contacts action should handle users associated with any deleted place #648
• Add some metadata onto documents when they get moved

Code review items

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or integration tests where appropriate
• Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[jkuester]

I have started looking at this and reading through the related issues. Unfortunately, I will be OOO the rest of this week, but I plan to give this a proper review when I am back early next week. 👍

[kennsippell]

@jkuester I'm very impressed with the depth of code review you provided. I bet that took a lot of time. Feedback is a gift, so thank you for your time.

[jkuester]

@kennsippell Thank you for hanging in there with me on this one! IMHO your refactors here have dramatically improved the maintainability of the code base (and as I said before, the new functionality is critical).

(FYI, trying out the conventional commits comment-style here. If you have any feedback good/bad/indifferent, drop it out on that Slack thread!)

I found one issue with the error message if you pass root as the destination, but otherwise just a couple minor suggestions and additional tests cases. Otherwise, this is good to go!

[medic-ci]

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀