Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#596): fix issue with semver #598

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix(#596): fix issue with semver #598

merged 1 commit into from
Jan 10, 2024

Conversation

1yuv
Copy link
Member

@1yuv 1yuv commented Jan 10, 2024

Description

Fixes #596

Actual work was done on #597 , this one adds test and is for release purpose.

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@1yuv 1yuv requested review from kennsippell and jkuester January 10, 2024 22:57
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@1yuv 1yuv merged commit 86a9954 into main Jan 10, 2024
12 checks passed
@1yuv 1yuv deleted the 596_fix_release branch January 10, 2024 23:03
@medic-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest cht-conf fails to upgrade app settings to latest CHT endpoints
3 participants