Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#593): properly resolve the path to webpack loaders #594

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

m5r
Copy link
Contributor

@m5r m5r commented Dec 14, 2023

Description

use require.resolve to get the proper path to the webpack loader

#593

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@m5r m5r requested a review from jkuester December 14, 2023 17:20
@m5r
Copy link
Contributor Author

m5r commented Dec 14, 2023

@jkuester could you review this fix? With this deployed, we can upgrade CHT core to use CHT conf 3.22
It will fix the couple of integration and e2e tests that were failing after upgrading to 3.21

Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I was unable to repro the error, but that may be related to the version of cht-core I was using to test with. Either way, this branch works fine for me and based on my reading of using require.resolve in your webpack config seems to be that it is recommended anyway....

@m5r m5r merged commit 0c015f9 into main Dec 14, 2023
12 checks passed
@m5r m5r deleted the 593-resolve-webpack-loaders branch December 14, 2023 19:47
@medic-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants