Why 5? wtf

medic · Dec 6, 2024 · 8f2bbd6 · 8f2bbd6
1 parent 42c6789
commit 8f2bbd6
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/lib/hierarchy-operations/index.js b/src/lib/hierarchy-operations/index.js
@@ -47,7 +47,7 @@ function moveHierarchy(db, options) {
 
       minifyLineageAndWriteToDisk(options, [...updatedDescendants, ...updatedAncestors]);
 
-      const movedReportsCount = await moveReports(db, options, moveContext, destinationId);
+      const movedReportsCount = await moveReports(db, options, moveContext);
       trace(`${movedReportsCount} report(s) created by these affected contact(s) will be updated`);
 
       affectedContactCount += updatedDescendants.length + updatedAncestors.length;
@@ -166,16 +166,18 @@ function replaceLineageInContacts(options, moveContext) {
     }
   }
 
-  const result = [];
-  for (const doc of moveContext.descendantsAndSelf) {
+  function sonarQubeComplexityFiveIsTooLow(doc) {
     const docIsSource = doc._id === sourceId;
 
     // skip top-level because it will be deleted
-    if (options.merge && docIsSource) {
-      continue;
+    if (!options.merge || !docIsSource) {
+      return replaceForSingleContact(doc);
     }
+  }
 
-    const updatedDoc = replaceForSingleContact(doc);
+  const result = [];
+  for (const doc of moveContext.descendantsAndSelf) {
+    const updatedDoc = sonarQubeComplexityFiveIsTooLow(doc);
     if (updatedDoc) {
       result.push(updatedDoc);
     }