#596 fix issue with semver validation for latest versions

medic · Jan 5, 2024 · 1a1cc09 · 1a1cc09
1 parent 958f0b4
commit 1a1cc09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/fn/upload-app-settings.js b/src/fn/upload-app-settings.js
@@ -39,7 +39,7 @@ async function augmentDeclarativeWithNoolsBoilerplate(appSettings) {
   }
 
   const actualCoreVersion = await getValidApiVersion(appSettings);
-  const addNoolsBoilerplate = semver.lt(actualCoreVersion, '4.2.0-dev');
+  const addNoolsBoilerplate = actualCoreVersion && semver.lt(actualCoreVersion, '4.2.0-dev');
   if (addNoolsBoilerplate) {
     appSettings.tasks.rules = nools.addBoilerplateToCode(appSettings.tasks.rules);
 

diff --git a/src/lib/get-api-version.js b/src/lib/get-api-version.js
@@ -18,7 +18,7 @@ const getApiVersion = async () => {
 };
 
 const getValidApiVersion = async () => {
-  return semver.valid(await getApiVersion());
+  return semver.valid(semver.coerce(await getApiVersion()));
 };
 
 module.exports = { getValidApiVersion };