fix: correct indentation for macOS activation policy in main.rs #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
can you share video of app working |
Github CI/CL working? |
|
i dont get what this PR is doing tbh, build works https://github.com/mediar-ai/screenpipe/actions/runs/12663602032/job/35291164994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: [pull request](fix: correct indentation for macOS activation policy in main.rs)
about: removed the second cfg macos, one is enough to use it correctly
title: "[pr] "
labels: ''
assignees: ''
description
just removed the second cfg macos issue, now window is building on github actions just fine and test results on windows are good as well. unless you meant the ollama build, which still builds and has a long time to run to be honest.
/claim #1100
related issue: #1100
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time.
would only take 5 minutes at most to be honest.