Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed event handler for displaying comments and adding markers to the timeline #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jp-rad
Copy link

@jp-rad jp-rad commented Jan 30, 2023

Fixed event handler for displaying comments and adding markers to the timeline

#694

Description

Changing loadedmetadata event to loadeddata event, because called after initialize().

initialize()
https://github.com/mediacms-io/mediacms/blob/main/frontend/src/static/js/components/comments/videojs-markers.js#L454

The original onCommentsLoad function was separated into the onCommentsLoad function and the retrieveComments function.

@mgogoulos
Copy link
Contributor

Hi @jp-rad
I've checked out this PR and have the following questions:

  1. Is this ready to be merged or you have concerns? Not sure I understand what is the case on TIMESTAMP_IN_TIMEBAR does not work. #694 (comment)
  2. The big problem remains after update to latest video.js and is the fact that when you visit a media URL that has timestamp, the video starts on this timestamp but IMMEDIATELY afterwards goes back to the beginning. This behaviour wasn't happening before. Do you have any idea how this can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants