Use blasfeoConfig.cmake when building with BUILD_WITH_BLASFEO=OFF #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant more as a proposal/discussion rather then a finished PR.
While removing the patch #18 from the conda-forge recipe of fatrop as 0.0.4 release of fatrop was released, I noticed the only remaining patch was this one.
Basically,
blasfeo
when installed installs ablasfeoConfig.cmake
file, sofind_package
can be used directly instead of manually callingfind_path
andfind_library
and creating an imported target. This works fine in my tests, but if you have any setup with an external blasfeo you want to support, feel free to ask (for example, we could simply add/opt/blasfeo
to thePATHS
argument offind_package
if useful).fyi @nim65s as he could have an opinion on this based on nix packaging of fatrop.