Better adaptors pt 3 #198
Merged
Better adaptors pt 3 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
flatten-adaptors-onto-external-fields
to
main
November 2, 2023 18:03
Running the dispatcher on each change is expensive, and waiting for it to run before showing the user's input creates a significant lag. This change uses local state for all inputs, to give the user immediate feedback, and debounces the dispatcher call. useDeferredValue doesn't help us here, since the reducer is expensive regardless of the UI render.
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
02f0482 to
08b6d4d
Compare
This prevents loading spinner from showing when resolveData returns instantly
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
6c2ec59 to
a2da8fc
Compare
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
a2da8fc to
8c9bb9a
Compare
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
2c78348 to
d5f29da
Compare
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
d5f29da to
a77da48
Compare
Open
chrisvxd
force-pushed
the
better-adaptors-pt-3
branch
from
a77da48 to
8183138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a third round of improvements to adaptors, plus related issues.