fix: puck header style for #168 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yuddomack is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Sorry for slow review but looks good @Yuddomack! One minor comment.
chrisvxd
requested changes
Oct 25, 2023
| @@ -318,7 +318,7 @@ export function Puck({ | |||
| display: "grid", | |||
| padding: 16, | |||
| gridTemplateAreas: '"left middle right"', | |||
| gridTemplateColumns: "288px auto 288px", | |||
| gridTemplateColumns: "288px auto 344px", | |||
There was a problem hiding this comment.
@Yuddomack thanks for updating, although you missed my other comment:
Suggested change
| gridTemplateColumns: "288px auto 344px", | |
| gridTemplateColumns: "344px auto 344px", |
Yuddomack
force-pushed
the
feature/overrun_long_head_title
branch
from
b25468f to
995b386
Compare
chrisvxd
approved these changes
Oct 26, 2023
|
Merged, thanks @Yuddomack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I slightly modified the style of the header area for #168