Add deprecated warning to readme #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read more: - meanjs/mean#1446 - meanjs/mean#1528
|
Ping @roieki & @lirantal — I recon after merging this the repo could be abandoned and people would stop wasting time opening new issues here and at the main MEAN repo. |
|
I never maintained this repo so I'm not sure I can speak for @roieki but I guess he hasn't be that active and if it causes confusion then we can probably close it. Maybe we can pull in @codydiag or @ilanbiala to confirm/raise concerns? |
|
@lirantal this could be cleaned out as well: https://meanjs.org/modules.html |
|
yeah that makes sense, thanks. |
|
I've never actually worked with this repo either. I think a deprecated/caution header is good if Google has fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has deprecated (10/2015)
_escaped_fragment_URL parameter and can now scrape javascript generated pages and thus this package isn't needed anymore at MEAN.js projects.Read more: