Skip to content

Commit

Permalink
Merge pull request #221 from mean-expert-official/development
Browse files Browse the repository at this point in the history
(WIP) 2.1.0-rc.1
  • Loading branch information
jonathan-casarrubias authored Dec 1, 2016
2 parents 9f7b483 + 828594f commit e8f2817
Show file tree
Hide file tree
Showing 100 changed files with 3,020 additions and 5,005 deletions.
44 changes: 37 additions & 7 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,43 @@
#### What type of pull request are you creating?
- [ ] Bug Fix
- [ ] Enhancement
- [ ] Documentation

#### How many unit test did you write for this pull request?
# How to contribute

I'm really glad you're reading this, volunteer developers to help this project are always welcome.

If you haven't already, follow me ([@johncasarrubias](irc://chat.freenode.net/opengovernment) on twitter). I want you to keep informed about new features and tutorials.

Write a reason if none (e.g just fixed a typo):
Here are some important resources:

* [MEAN Expert Blog](http://mean.expert) tutorials about the MEAN Stack.
* [WIKI](https://github.com/mean-expert-official/loopback-sdk-builder/wiki) official wiki documentation.
* [Angular 2 Testing](https://angular.io/docs/ts/latest/guide/testing.html) official documentation for testing environment.
* Bugs? [GitHub Issues](https://github.com/mean-expert-official/loopback-sdk-builder/issues) is where to report them

#### Please add a description for your pull request:
## Adding Issues
If you find any bug or enhancement, you are always welcome to create a [New Issue](https://github.com/mean-expert-official/loopback-sdk-builder/issues).

## Pull Request
If you would like to contribute by adding new features, enhancements or by fixing bugs; please consider that you need to create an issue prior your pull request. This is important for tracking purposes in CHANGELOG.

**IMPORTANT: Make sure you create a branch from `development` and then create the pull request also to development and not to master.**

Please send a [GitHub Pull Request](https://github.com/mean-expert-official/loopback-sdk-builder/pull/new/development) with a clear list of what you've done (read more about [pull requests](http://help.github.com/pull-requests/)). When you send a pull request, we will love you forever if you include RSpec examples. We can always use more test coverage. Please make sure all of your commits are atomic (one feature per commit).

Always write a clear log message for your commits. One-line messages are fine for small changes, but bigger changes should look like this:

$ git commit -m "A brief summary of the commit
>
> A paragraph describing what changed and its impact."

Most of the times you will need to add a new test or we may not be able to integrate it. Though, there are some cases when you don't need to add a unit test, like fixing a typo, adding a missing type, etc.

## Testing

Tests are being created and excecuted by using the Angular-CLI Tool, please refer to the official documentation.

````sh
$ cd to/loopback-sdk-builder
$ npm test
````

Thanks,
Jonathan Casarrubias, [MEAN Expert](http://mean.expert).
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#### What version of this module are you using?
- [ ] 2.0.10 (Stable)
- [ ] 2.1.0-beta.14
- [ ] 2.1.0-rc.n (2.1 Release Candidate n)
- [ ] Other

Write other if any:
Expand Down
42 changes: 7 additions & 35 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,40 +1,12 @@
# How to contribute
#### What type of pull request are you creating?
- [ ] Bug Fix
- [ ] Enhancement
- [ ] Documentation

I'm really glad you're reading this, volunteer developers to help this project are always welcome.
#### How many unit test did you write for this pull request?

If you haven't already, follow me ([@johncasarrubias](irc://chat.freenode.net/opengovernment) on twitter). I want you to keep informed about new features and tutorials.

Here are some important resources:
Write a reason if none (e.g just fixed a typo):

* [MEAN Expert Blog](http://mean.expert) tutorials about the MEAN Stack.
* [WIKI](https://github.com/mean-expert-official/loopback-sdk-builder/wiki) official wiki documentation.
* [Angular 2 Testing](https://angular.io/docs/ts/latest/guide/testing.html) official documentation for testing environment.
* Bugs? [GitHub Issues](https://github.com/mean-expert-official/loopback-sdk-builder/issues) is where to report them

## Adding Issues
If you find any bug or enhancement, you are always welcome to create a [New Issue](https://github.com/mean-expert-official/loopback-sdk-builder/issues).

## Pull Request
If you would like to contribute by adding new features, enhancements or by fixing bugs; please consider that you need to create an issue prior your pull request. This is important for tracking purposes in CHANGELOG.

Please send a [GitHub Pull Request](https://github.com/mean-expert-official/loopback-sdk-builder/pull/new/master) with a clear list of what you've done (read more about [pull requests](http://help.github.com/pull-requests/)). When you send a pull request, we will love you forever if you include RSpec examples. We can always use more test coverage. Please make sure all of your commits are atomic (one feature per commit).

Always write a clear log message for your commits. One-line messages are fine for small changes, but bigger changes should look like this:

$ git commit -m "A brief summary of the commit
>
> A paragraph describing what changed and its impact."

Most of the times you will need to add a new test or we may not be able to integrate it. Though, there are some cases when you don't need to add a unit test, like fixing a typo, adding a missing type, etc.

## Testing

Tests are being created and excecuted by using the Angular-CLI Tool, please refer to the official documentation.

````sh
$ cd to/loopback-sdk-builder
$ npm test
````

Thanks,
Jonathan Casarrubias, [MEAN Expert](http://mean.expert).
#### Please add a description for your pull request:
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,27 @@

This file is created to keep history of the LoopBack SDK Builder, it does not consider or keeps any history of its parent module `loopback-sdk-angular`.

## Release 2.1.0-rc1

- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/232
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/231
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/228
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/201
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/223
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/220
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/31
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/199
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/210
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/209
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/208
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/207
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/206
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/36
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/205
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/204
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/203
- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/202

## Release 2.1.0-beta.17

- Fix: https://github.com/mean-expert-official/loopback-sdk-builder/issues/190
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![npm version](https://badge.fury.io/js/%40mean-expert%2Floopback-sdk-builder.svg)](https://badge.fury.io/js/%40mean-expert%2Floopback-sdk-builder) [![Build Status](https://travis-ci.org/mean-expert-official/loopback-sdk-builder.svg?branch=development)](https://travis-ci.org/mean-expert-official/loopback-sdk-builder) [![dependencies](https://david-dm.org/mean-expert-official/loopback-sdk-builder.png)](https://david-dm.org/mean-expert-official/loopback-sdk-builder) [![Known Vulnerabilities](https://snyk.io/test/npm/@mean-expert/loopback-sdk-builder/badge.svg)](https://snyk.io/test/npm/@mean-expert/loopback-sdk-builder)
[![npm version](https://badge.fury.io/js/%40mean-expert%2Floopback-sdk-builder.svg)](https://badge.fury.io/js/%40mean-expert%2Floopback-sdk-builder) [![Build Status](https://travis-ci.org/mean-expert-official/loopback-sdk-builder.svg?branch=development)](https://travis-ci.org/mean-expert-official/loopback-sdk-builder) [![dependencies](https://david-dm.org/mean-expert-official/loopback-sdk-builder.png)](https://david-dm.org/mean-expert-official/loopback-sdk-builder)

![LoopBack SDK Builder](https://storage.googleapis.com/mean-expert-images/sdk-builder.jpg)

Expand Down
21 changes: 15 additions & 6 deletions bin/lb-sdk
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,20 @@ var argv = optimist
.usage('\n******************************************* LoopBack SDK Builder 2.0 *******************************************\n' +
'\nGenerate Client SDK for your LoopBack Application.' +
'\nUsage:' +
'\n ./node_modules/.bin/lb-sdk server/server app/shared/sdk -d [ng4web | nativescript2] -i [enabled | disabled]')
'\n ./node_modules/.bin/lb-sdk server/server app/shared/sdk -d [ng2web | ng2native | ng2universal] -i [enabled | disabled] -v [enabled | strict | disabled]')
.describe('l', 'Client\'s library (angular2, react <todo>, ...)')
.describe('d', 'Platform specific drivers (ng4web, nativescript2, ng2universal <todo>)')
.describe('d', 'Platform specific drivers (ng2web, ng2native, ng2universal)')
.describe('i', 'Enable PubSub, IO and FireLoop functionality')
.describe('w', 'Automatically wipe SDK Directory')
.describe('v', 'Add default values in models')
.describe('f', 'Generate only FireLoop SDK + Auth Services')
.default('l', 'angular2')
.default('d', 'ng4web')
.default('d', 'ng2web')
.default('i', 'enabled')
.default('w', 'disabled')
.alias({ u: 'url', m: 'module-name', l: 'library', i: 'io', d: 'driver', w: 'wipe' })
.default('v', 'disabled')
.default('f', 'disabled')
.alias({ u: 'url', m: 'module-name', l: 'library', i: 'io', d: 'driver', w: 'wipe', v: 'default-values', v: 'fireloop-only' })
.demand(1)
.argv;
/**
Expand All @@ -56,6 +60,9 @@ console.log(chalk.green('* Sylvain Dumont <https://www.w
console.log(chalk.green('* Yonggang Luo <https://github.com/lygstate> *'));
console.log(chalk.green('* Chris Tunbridge <https://github.com/Destreyf> *'));
console.log(chalk.green('* Miguel Serrano <https://github.com/Serranom4> *'));
console.log(chalk.green('* Julien Ledun <https://github.com/jledun> *'));
console.log(chalk.green('* Paul Robinson <http://nextfaze.com> *'));
console.log(chalk.green('* Corentin Hatte <https://github.com/viki53> *'));
console.log(chalk.green('* *'));
console.log(chalk.green('* ORIGINALLY FORKED FROM *'));
console.log(chalk.green('* Miroslav Bajtos\' <[email protected]> *'));
Expand Down Expand Up @@ -89,8 +96,10 @@ var context = {
apiUrl: argv['url'] || app.get('restApiRoot') || '/api',
outputFolder: argv._[1],
isIo: argv['i'] || 'disabled',
driver: argv['d'] || 'ng4web',
wipe: argv['w'] || 'disabled'
driver: argv['d'] || 'ng2web',
wipe: argv['w'] || 'disabled',
defaultValue: argv['v'] || 'disabled',
fireloopOnly: argv['f'] || 'disabled'
};

function verifyPath() {
Expand Down
9 changes: 0 additions & 9 deletions lib/angular2/drivers/nativescript2/socket.driver.ejs

This file was deleted.

12 changes: 0 additions & 12 deletions lib/angular2/drivers/ng4web/storage.driver.ejs

This file was deleted.

Loading

0 comments on commit e8f2817

Please sign in to comment.