Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove kitchen timer #4857

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: remove kitchen timer #4857

merged 2 commits into from
Jan 7, 2025

Conversation

Kuchenpirat
Copy link
Collaborator

@Kuchenpirat Kuchenpirat commented Jan 7, 2025

What this PR does / why we need it:

Removes the kitchen timer.
As described in #4467 timers run through the PWA or the web app suffer from the limitation that they can only ring when the page that they are on is currently opened. This leads to the situation that they are inherently unreliable and we should push people to using reliable timers by just not including an unreliable on in mealie.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Removed the Component, the translation and the icons.
original implementation in #2508

Testing

Manual

@github-actions github-actions bot added the bugfix label Jan 7, 2025
@michael-genson michael-genson enabled auto-merge (squash) January 7, 2025 19:13
@michael-genson michael-genson merged commit 0f7c1d6 into mealie-next Jan 7, 2025
14 checks passed
@michael-genson michael-genson deleted the remove-kitchen-timer branch January 7, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants