-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new labels and foods for en-US language. Update all locale seeding files and seeding logic to parse the new format Only add new labels, units, and foods during seeding (checking against existing names) #4812
base: mealie-next
Are you sure you want to change the base?
feat: Add new labels and foods for en-US language. Update all locale seeding files and seeding logic to parse the new format Only add new labels, units, and foods during seeding (checking against existing names) #4812
Conversation
I just want to say thank you for the credit and completing what I set out to do. Let me know if I can be of help. |
A big thank you to @parumpum as well for their help on discord |
Thanks for the callout! A nice complement to this would be a way to run the seed in an Update mode. Not sure if this should maybe be a separate function altogether, or a toggle. That could be up for discussion. Personally I would like to see if the food already exists, move on to check plural name and label. Update currently empty fields, leave others alone. This wouldn't clobber any existing data or create a bunch of duplicates. |
Well I went through and incorporated all existing, and so many foods and plurals, I can't imagine any missing. I'm not sure how many recipes call for "cacti" but we got that and many others covered. Lol. |
…foods seed list instead of their own. Link foods to labels when seeding.
…abel, and unit seeding to query all existing items and then only seed new ones, making it less likely to get duplicates from seeding. Updated messages on group data management page. Updated tests
… all locales to use the new format
5ef3e5b
to
1d9b981
Compare
Moved to ready for review - looking forward to any feedback on my first Mealie PR |
a7f8b64
to
1d9b981
Compare
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This is based off of the work in PR #3037. @catduckgnaf did a tremendous amount of work creating the new labels and foods, so credit to them. I modified the format of the en-US.json file based on the feedback provided in that thread, primarily to modify the file so that each key was a label and that there was a value called
foods
which is a dictionary where each key is the english name of the food and the value is the attributes of the food, including the translated named of the food.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1230
Also based on the work in PR #3037
Special notes for your reviewer:
(fill-in or delete this section)
I updated the en-US.json foods seeding file based on the feedback in PR #3037 by @hay-kot.
All food seeding locale files were updated to use the new format
Testing
(fill-in or delete this section)