-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add recipe as ingredient #4800
Open
parumpum
wants to merge
23
commits into
mealie-recipes:mealie-next
Choose a base branch
from
parumpum:feat/recipe-links
base: mealie-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed feedback in Discord:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds the ability to reference another recipe in a recipe's ingredients. A reference to the recipe is added to a new column for table recipes_ingredients. This can be utilized to determine if the ingredient is a food, a recipe, or just a note.
Adding recipe to shopping list will loop through the ingredients list, cascading down into recipes if it finds any to add individual ingredients to the shopping list.
Clicking the referenced recipe will open a new tab to the recipe
Added select all / none buttons to each section of the Add To Shopping List dialog
Linked recipes will show up as a section in this dialog, the select all / none buttons on each section make it easy to include or exclude several ingredients at once.
Which issue(s) this PR fixes:
#1761
Testing
Tested by linking recipes together, adding ingredients to shopping lists
Unit test that adds a recipe to another recipe as an ingredient
Modified referenced recipe name and ingredients, verified changes were picked up on main recipe page