-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for plural_name for foods #4305
feat: Added support for plural_name for foods #4305
Conversation
@hay-kot could you try to review this before you update Crowdin again and I have to redo it? If you don't think this PR is a good idea just let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we'd just need to double check Crowdin after merge just be ready to revert in case anything goes wrong. Will wait for another approval before I merge.
@michael-genson looked at the original PR but I believe was waiting for your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, LGTM too!
Destroyed PR #4129 when trying to rebase. Was just easier to create a new PR.
What type of PR is this?
What this PR does / why we need it:
This PR allows the seeder to import plural names for foods.
This allows for new user have cleaner ingredient lists without having to do any additional configuration.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Testing
Ran a fresh install and all of the plural ingredients were seeded properly: