Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for plural_name for foods #4305

Conversation

Choromanski
Copy link
Contributor

Destroyed PR #4129 when trying to rebase. Was just easier to create a new PR.

What type of PR is this?

  • feature

What this PR does / why we need it:

This PR allows the seeder to import plural names for foods.
This allows for new user have cleaner ingredient lists without having to do any additional configuration.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  1. This work was discussed in feat: Seed support for plural units #3933
  2. If anything is done that causes issues with crowdin let me know and I can work to resolve it.
  3. I only provided plurals for foods that would normally be the unit (ex. 1 watermelon)
  4. I sorted the list by keys so that I could de-duplicate easier
  5. I also removed some words that were duplicated in there UK equivalent (ex. aubergine/eggplant, broad/fava beans, icing/powdered sugar)
  6. Any comments or recommendations would be greatly appreciated

Testing

Ran a fresh install and all of the plural ingredients were seeded properly:
image

@Choromanski
Copy link
Contributor Author

@hay-kot could you try to review this before you update Crowdin again and I have to redo it?

If you don't think this PR is a good idea just let me know.

@hay-kot hay-kot requested a review from michael-genson October 9, 2024 02:46
Copy link
Collaborator

@hay-kot hay-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we'd just need to double check Crowdin after merge just be ready to revert in case anything goes wrong. Will wait for another approval before I merge.

@Choromanski
Copy link
Contributor Author

@michael-genson looked at the original PR but I believe was waiting for your approval.

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM too!

@michael-genson michael-genson merged commit 01a43f2 into mealie-recipes:mealie-next Oct 9, 2024
13 checks passed
@Choromanski Choromanski deleted the feature/food-seed-plurals2 branch October 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants