fix: user full name on recipe comments #4295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OozyGrub
force-pushed
the
mealie-next
branch
2 times, most recently
from
0b0c367 to
3a6ca0f
Compare
Kuchenpirat
reviewed
Oct 9, 2024
| @@ -54,6 +54,7 @@ def test_create_comment(api_client: TestClient, unique_recipe: Recipe, unique_us | |||
| assert response_data[0]["recipeId"] == str(unique_recipe.id) | |||
| assert response_data[0]["text"] == create_data["text"] | |||
| assert response_data[0]["userId"] == str(unique_user.user_id) | |||
| assert len(response_data[0]["user"]["fullName"]) > 0 | |||
There was a problem hiding this comment.
I think it would make sense to add fullName to our TestUser so we can compare the result directly. Is that something you could do?
6 tasks
6 tasks
|
This PR is stale because it has been open 45 days with no activity. |
|
As this seems to be abandonned i'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this
What this PR does / why we need it:
Use a full name in recipe comment instead of username.
Which issue(s) this PR fixes:
#4187
Special notes for your reviewer:
Please tag this PR as hacktoberfest, thanks
Testing
Test locally before & after.
Before
After