Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from poetry to pip so that omni build succeeds for ARMv7 (32bit) #2496

Closed
wants to merge 1 commit into from

Conversation

lowlyocean
Copy link

@lowlyocean lowlyocean commented Aug 13, 2023

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #706

Special notes for your reviewer:

This depends on 32-bit crfpp image being built, which requires mealie-recipes/crfpp#1 to be approved (and resulting image pushed to Docker Hub). I've not totally cleaned this up - please feel free to contribute as needed, my time is limited but I do think that supporting 32-bit ARM builds again is worthwhile (since I would wager that many Raspberry Pis are 32-bit, and many people that self-host web services like Mealie are doing so with Raspberry Pis).

Testing

(fill-in or delete this section)

Tested by cross-compiling armv7 docker image on an amd64 machine (I first needed to cross-compile armv7 docker image for crfpp), and then successfully deploying it on 32-bit Raspberry Pi. Works when served behind my Nginx (acting as reverse proxy).

Release Notes

(REQUIRED)

Support ARMv7 builds again, to produce omni images for 32-bit Raspberry Pi

@hay-kot
Copy link
Collaborator

hay-kot commented Aug 16, 2023

To be honest, after fighting with and dealing with 32bit arm builds and losing days to it, I don't have much of an interest in officially managing a release for that. I don't think there's really any convincing.

What I would be open to would be moving to pip-tools which would allow you or others to more easily maintain an unofficial 32bit arm build. In that case, I'd be happy to link to those images in the docs as community builds.

I don't know if that would be a happy medium we could come to here. Let me know what you think

@hay-kot hay-kot marked this pull request as draft August 20, 2023 18:22
@hay-kot hay-kot closed this Oct 7, 2023
@ekcom
Copy link
Contributor

ekcom commented Dec 14, 2023

Note that most RPis can run a 64 bit OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No matching manifest for linux/arm/v7 in the manifest list entries
3 participants