147 [deployment] Add Fluentd to docker environment. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannis-mlgrn
approved these changes
Nov 11, 2021
|
Fluentd is actually useless if we don't feed it with our applications/containers logs (I don't think it's done automatically). In my understanding we need to use fluentd log driver for each containers. See the documentation here : https://docs.fluentd.org/v/0.12/container-deployment/docker-compose#step-0-prepare-docker-compose.yml This PR should be more complete :
|
Benvii
reviewed
Nov 14, 2021
| - "elasticsearch" | ||
| ports: | ||
| - "24224:24224" | ||
| - "24224:24224/udp" |
There was a problem hiding this comment.
Fluentd logging divers isn't set on at least one of our containers (see my comment on the PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fluentd image, configuration in docker environment.
Needs elasticsearch: next PR.