-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings about using URI.escape method #35
base: master
Are you sure you want to change the base?
Conversation
Envek
commented
Mar 2, 2020
- Replace obsolete URI.escape method with CGI.escape (no specs failed so it should be fine, I think)
- Fix deprecation warnings about using ActionView::Base.new in specs
- Include newer Rails and Ruby versions into CI matrix
Exclusions are based on allowed Ruby/Rails versions: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#ruby-versions
@mdeering would be great to get this one merged. Thanks |
@mdeering any chance of getting this merged and released? |
If we can't get it merged and @mdeering isn't responding, is there a more up to date fork of this gem the community is using? |
Get rid of the dependency with a simple helper
|
thanks @olimart!
|
@mdeering can we get this merged, please? It breaks when upgrading to ruby 3. Thank you! |