Prevention alpha == beta - 1 in qsearch function for PvNode
#324
Conversation
|
Please stop posting PR's for SF. You have no idea what you are doing and you're wasting everyone's time. Anyone with write ability here should immediately close this PR and ask Github to ban this psychopathic troll. |
|
@protonspring Please note a few points before judging:
A- For PvNode, the value of "beta - alpha" must be greater than 1 So my PR was correct.
B- If you doubt the correctness of my PR, you can test it Fishtest.
C- Even if my test was 1% wrong, why did the SF admin(vondele) block me?
D- Also we have this assert "PvNode || alpha == beta - 1" in place
https://github.com/official-stockfish/Stockfish/blob/df0fb8471e5015bb4ba0b398c203b7faad45840e/src/search.cpp#L1406
|
|
You were blocked because you have no idea what you are doing and you are wasting everyone's time. I would have blocked you much earlier. Pinging 50 people is very rude and irritating. Making additional fake accounts is rude and mean. You are an awful person and no one want to deal with you. Please go do something else. |
|
Please be nice to me. I did not waste anyone's time. Base of this assert, NodeType should be PVNode or Alpha == Beta -1 Value qsearch(Position& pos, Stack* ss, Value alpha, Value beta, Depth depth) {
static_assert(nodeType != Root);
constexpr bool PvNode = nodeType == PV;
assert(alpha >= -VALUE_INFINITE && alpha < beta && beta <= VALUE_INFINITE);
assert(PvNode || (alpha == beta - 1));
assert(depth <= 0);Is it possible for the NodeType to be both PVNode and Alpha == Beta -1 ?! |
|
Considering the extraordinary level of noise you're generating, it might be best if you test your own PR before submitting it again (not just a speed test, but also a comprehensive strength test). |
|
Unfortunately, I confirm that I have been banned from official-stockfish .
And I had participated in 2 other discussions:
After a few days, I realized that I could not do any actions on Official_Stockfish.It was there that I found out that my account is blocked. Probably my blocking is because of my opposition with the Vondele commit.
After talking with Fishtest admin(@ppigazzini), I came to the conclusion that a new organization (@official-fishtest) should be built where honesty and freedom come first. |
|
We can only hope that you go and build a new organization where honesty and freedom come first. Please do so as soon as possible and leave us alone. |
|
you don't really need permission of fishtest admins to call mental institution |
|
I could link like a dozen posts that tell you exactly why, but something tells me that would be a waste of time. |
|
@ginkgo20 |
|
Unfortunately Only one week after the creation of @official-fishtest, they transferred the Fishtest to @official-stockfish. |
|
So... run your own fishtest server and spend your own resources proving that this is a strength improvement instead of wasting everyone else's time and resources. |
|
😂 Absolutely bonkers. lol |
|
@atumanian I checked your comments and posts. See these 3 Commits from 3 different person official-stockfish/Stockfish@0c1f119 official-stockfish/Stockfish@741523e official-stockfish/Stockfish@3f44f53 Because of you Stockfish could improve very much , Why did they block you for no reason? The only way to solve this problem is to have a face-to-face meeting with the head of Stockfish (@vondele) |
|
😂😂😂😂😂. Yes. do that. |
|
Unfortunately, I confirm that I have been banned from Stockfish-related discord channels. |
https://tests.stockfishchess.org/tests/finished?ltc_only=1 simply refutes that claim, with billions of long time control tests having been performed by people who understand what they are doing. |
|
STC= 5s+0.1s |
|
Sorry, I had the wrong URL: |
Absolutely Correct. At that time ShashChess was ranked first in the CCRL and Stockfish didn't show in chess ranking. I asked the manager of CCRL about the Elo difference and he said that the rating is correct.
At that time I suggested to @amchess that he merge a PR that would make ShashChess the world No. 1 chess ranking forever But @amchess didn't accept my suggection.
|
|
Dogs bark and cats meow. Agree? Disagree? |
I'ts normal: ShashChess has a different testing strategy. I don't agree with the one of Stockfish community, because our goal are different. Clearly, I deeply respect their work. |
Right... but my PR only improves search tree without functional changes associated with engines difference. // Internal iterative deepening (~10 Elo)
if (depth >= 8
&& !ttMove)
{
search<nodeType>(pos, ss, alpha, beta, depth - 7, cutNode);
tte = TT.probe(posKey, ss->ttHit);
ttValue = ss->ttHit ? value_from_tt(tte->value(), ss->ply, pos.rule50_count()) : VALUE_NONE;
ttMove = ss->ttHit ? tte->move() : MOVE_NONE;
}The distance between ShashChess and Stockfish is only 10 ELO. I think my PR make ShashChess the world No. 1 chess ranking.
|
Sorry, I don't understand how these 3 commits are related to your topic. Yes, I was indeed blocked (and still am) by Vondele from the official-stockish organization for no legitimate reason. I wrote about it in the Fishcooking forum. |
|
I dont think anyone understands this thread either. |
|
@atumanian You are the creator of the idea of These 3 Commits from 3 different person are derived from your commit.
Because of you Stockfish improved very much but @vondele blocked you and wouldn't hear you out. |
|
|
If i had a ban hammer, i would ban all you nut jobs just because you have no idea what you are doing and you are wasting everyone's time. This thread is a pointless reflection of one lunatic. |
|
Unfortunately, I confirm that I have been banned from official-stockfish. My PR is able to detect all valid fens and prevent Stockfish from crashing. \s*([rnbqkpRNBQKP1-8]+\/){7}([rnbqkpRNBQKP1-8]+)\\s[bw-]\\s(([a-hkqA-HKQ]{1,4})|(-))\\s(([a-h][3-6])|(-))\\s\\d+\\s\\d+ \s*I am very thankful to @ppigazzini for helping me honestly.❤
|
|
ok. i am out. good luck. |
|
The only hope is to merge all of this PR somewhere else. @ddugovic Would you allow us to merge this PR into your repository? I believe ddugovic-stockfish can be better than official-stockfish. |
|
Nah, protonspring has the right idea here. Sorry. |
This confirms, regarding the dictatorial attitude of Stockfish administrators, that, as we say in our neck of the woods, 'most human beings like to be whipped by their own asses' |
|
i also whip other people with my own ass, but only when they like it. |
|
@ginkgo20 |
|
Effective projects benefit from a benevolent dictator, as does official-SF. Not sure why tens of thousands of other code submissions actually follow contribution guidelines and developers of this patch feel they don't need to follow those same guidelines. |
Heck if I know; contribution guidelines are obviously posted at https://github.com/official-stockfish/Stockfish for the curious, and don't seem to have been followed to the letter. Yes, there was some feeble attempt, however the "issue" and PR descriptions were vague and unpersuasive, fixating on a single position and failing to concisely explain untested changes in such a manner which could persuade maintainers. |
|
If everyone just joined his "master class" all would be well. This amount of arrogance demonstrates a certain level of mental illness. |
Wrong. When I was banned from the official-stockfish, I was commenting in two different threads.
Pay attention to the time of posting my comments so that you notice that I was commenting on 2 threads at the same time.
@ddugovic 8 other people also commented there why none of them were blocked? Worse than that, these are the abusive messages that Stockfish members sent to @amchess.
@ddugovic Please see the above comments. Shouldn't these people have been blocked? @ddugovic I wasn't blocked for not following the guidelines... I was blocked for posting a comment against Vondele's commit about removal classical evaluation.
|
|
You seem to have found your answer then... I hadn't realized how multitudinous discord had become, although my assessment still seems to hold true. |
|
Your PR doesn't relate to an open issue; and even if it did, other contributors' PRs on the same subject have already been rejected (if you search the PR history). Maintainers contend that FEN validation isn't Stockfish's responsibility. |
Are you asking my opinion, or telling me what my opinion should be? |
|
@ddugovic Clearly you haven't attended his master class. |
|
See my previous answer; clearly you are telling me what to think and have zero interest in my actual opinion which I have already offered. |
|
😂 |
|
@ddugovic Crashing on wrong input is called a bug for 99.9% of the computer science community. You chose to crash as a way to respond to the caller on an invalid request. This is a wrong approach. SF should never crash or even exit without the explicit request to exit. Instead of thanking me for creating this PR, they block me?
No. We had a function for FEN validation in old Stockfish versions. Please see this: bool Position::is_valid_fen(const std::string &fen) {
std::istringstream iss(fen);
std::string board, side, castleRights, ep;
if (!iss) return false;
iss >> board;
if (!iss) return false;
iss >> side;
if (!iss) {
castleRights = "-";
ep = "-";
} else {
iss >> castleRights;
if (iss)
iss >> ep;
else
ep = "-";
}
// Let's check that all components of the supposed FEN are OK.
if (side != "w" && side != "b") return false;
if (castleRights != "-" && castleRights != "K" && castleRights != "Kk"
&& castleRights != "Kkq" && castleRights != "Kq" && castleRights !="KQ"
&& castleRights != "KQk" && castleRights != "KQq" && castleRights != "KQkq"
&& castleRights != "k" && castleRights != "q" && castleRights != "kq"
&& castleRights != "Q" && castleRights != "Qk" && castleRights != "Qq"
&& castleRights != "Qkq")
return false;
if (ep != "-") {
if (ep.length() != 2) return false;
if (!(ep[0] >= 'a' && ep[0] <= 'h')) return false;
if (!((side == "w" && ep[1] == '6') || (side == "b" && ep[1] == '3')))
return false;
}
// The tricky part: The board.
// Seven slashes?
if (std::count(board.begin(), board.end(), '/') != 7) return false;
// Only legal characters?
for (int i = 0; i < board.length(); i++)
if (!(board[i] == '/' || (board[i] >= '1' && board[i] <= '8')
|| piece_type_is_ok(piece_type_from_char(board[i]))))
return false;
// Exactly one king per side?
if (std::count(board.begin(), board.end(), 'K') != 1) return false;
if (std::count(board.begin(), board.end(), 'k') != 1) return false;
// Other piece counts reasonable?
size_t wp = std::count(board.begin(), board.end(), 'P'),
bp = std::count(board.begin(), board.end(), 'p'),
wn = std::count(board.begin(), board.end(), 'N'),
bn = std::count(board.begin(), board.end(), 'n'),
wb = std::count(board.begin(), board.end(), 'B'),
bb = std::count(board.begin(), board.end(), 'b'),
wr = std::count(board.begin(), board.end(), 'R'),
br = std::count(board.begin(), board.end(), 'r'),
wq = std::count(board.begin(), board.end(), 'Q'),
bq = std::count(board.begin(), board.end(), 'q');
if (wp > 8 || bp > 8 || wn > 10 || bn > 10 || wb > 10 || bb > 10
|| wr > 10 || br > 10 || wq > 9 || bq > 10
|| wp + wn + wb + wr + wq > 15 || bp + bn + bb + br + bq > 15)
return false;
// OK, looks close enough to a legal position. Let's try to parse
// the FEN and see!
Position p;
p.from_fen(board + " " + side + " " + castleRights + " " + ep);
return p.is_ok(true);
} |
|
Computer science has almost nothing to do with writing code. It's rare to find an actual community with common goals who concurrently do software development, because there are so many scaling problems; ironically, official-stockfish is one of the larger development communities.
Virtue signalling aside, you're proposing a solution without adequately defining the problem: https://xyproblem.info . But not only have you failed to define the problem, you have no clue what the larger problem is, despite the fact that it was already raised in one of the issues filed on the official-SF repo.
I've already said multiple times that the most effective free software projects benefit from having a benevolent dictator. Of course I disagree with the maintainer about sanitizing inputs, but they've made their stance clear and made clear that they don't like trolls, regardless of whether the troll is "right" or "wrong". Anyway... with thanks to Randall Munroe's "xkcd": |
|
official-stockfish/Stockfish#4446 Hi there, everyone! About a week ago, I posted a reply to a discussion in Official_Stockfish. Here is the my answer:
Today I realized that I have been banned from official_stockfish. This is while my comment is marked as an answer. I don't know who exactly blocked me but I guess @Sopel97 or @Disservin. |
|
Same idiot, new account. Nothing to see here. Please don't feed the trolls. |
|
@protonspring Please see official_stockfish's discussions. I had commented on @programarivm's thread before official-stockfish/Stockfish#4754, but I wasn't blocked. It's strange why I get blocked exactly when my comment is marked as an answer. |
ghost
mentioned this pull request
|
|
Here we go again. Cut and paste the retarded ramblings of a year ago. Rinse and repeat. Go go go. |
|
Make sure all of your accounts participate. That way, we might not think you are mentally ill. Just maybe ....... |
|
Dogs bark. Cats meow. Some people have nothing to do but pester people who are actually working. Oh, and the sky is blue, but only for some people. Soooo deep. |
|
The trumpet is a brass instrument commonly used in classical and jazz ensembles. The trumpet group ranges from the piccolo trumpet—with the highest register in the brass family—to the bass trumpet, pitched one octave below the standard B♭ or C trumpet. |
Hi Marco! Unfortunately, since you are not in the Stockfish organization, they do all kinds of disrespect and wrong behavior. It was some time ago that I made a PR #4575 but official-stockfish admins closed them without any explanation and other members disrespected me. I realized that they don't want anyone to disagree with them because they think they are king of programming. I request you to come back as soon as possible and end this injustice.
PvNodebug on qsearch function whenalpha == beta - 1official-stockfish/Stockfish#4575I mention examples of their disrespect here:
At first, Stockfish member (protonspring) insulted me and then stockfish admin (vondele) blocked me so I couldn't answer them.
This is my commits:
Finally, I ask stockfish authors to test my PR in fishtest to see how accurate it is:
@romstad @ianfab @mhouppin @vdbergh @Vizvezdenec @mstembera @atumanian @Dboingue @AlexandreMasta