Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.py --platform js success check may be faulty #278

Open
dan-rigdon-bel opened this issue May 12, 2020 · 3 comments
Open

build.py --platform js success check may be faulty #278

dan-rigdon-bel opened this issue May 12, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dan-rigdon-bel
Copy link
Member

I recently failed to build the javascript library using:

python scripts/build.py --platform js -o -v

because there was a build error. However, the script reported success (and the error was suppressed). I suspect the check for success is looking for a file and it is finding an older build and reporting success when it should not. This can be tested by artificially introducing a build error in the code.

@mcneel-build
Copy link

Linked with RH3DM-100

@dan-rigdon-bel dan-rigdon-bel self-assigned this May 12, 2020
@dan-rigdon-bel dan-rigdon-bel added the bug Something isn't working label May 12, 2020
@fraguada
Copy link
Member

fraguada commented Oct 5, 2023

Recent testing confirms that the appropriate files are removed with the -o flag

@fraguada fraguada closed this as completed Oct 5, 2023
@fraguada fraguada reopened this Dec 2, 2024
@fraguada
Copy link
Member

fraguada commented Dec 2, 2024

I've noticed that this is an issue on dotnet builds. build.py declares success, but there are errors reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants