Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: use scripts for javascript build #190

Closed
dan-rigdon-bel opened this issue Jan 17, 2020 · 3 comments · Fixed by #396
Closed

CircleCI: use scripts for javascript build #190

dan-rigdon-bel opened this issue Jan 17, 2020 · 3 comments · Fixed by #396
Labels

Comments

@dan-rigdon-bel
Copy link
Member

As of #189, we can now use:
script/boostrap.py --platform js (optional)
followed by:
script/setup.py --platform js --overwrite
followed by:
script/build.py --platform js --overwrite --verbose

This is (🤞) a more robust version of of src/build_javascript.py.

Once this is done, I believe src/build_javascript.py can be deleted.

Documentation is updated here:
https://github.com/mcneel/rhino3dm/blob/master/docs/javascript/RHINO3DM-BUILD.JS.md

I have only tested these scripts on macOS. If there are problems on linux, please let me know.

@mcneel-build
Copy link

Linked with RH3DM-73

@fraguada
Copy link
Member

UPDATE 2021.05.20: Circle CI still uses src/build_javascript.py while the build instructions use bootstrap, setup, build.py

@pearswj
Copy link
Member

pearswj commented May 20, 2021

I didn't do a good job of documenting why I didn't yet adopt the build scripts for the CI build, but #278 sounds familiar. Anyway, we ought to move to GitHub Actions to make it easier for other in the team to help maintain the builds (#373).

@pearswj pearswj removed their assignment May 20, 2021
fraguada added a commit that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants