Skip to content

Commit

Permalink
update mypy typing issues, remove python3.8 support
Browse files Browse the repository at this point in the history
  • Loading branch information
mcgillij committed Dec 31, 2022
1 parent 1358c31 commit 392bb18
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 10 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Python package

on:
Expand All @@ -15,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8, 3.9, '3.10']
python-version: [3.9, '3.10']

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion PKGBUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ depends=('python' 'python-yaml' 'python-numpy' 'python-rich' 'python-click')
makedepends=('python-setuptools')
url="https://github.com/mcgillij/amdfan"
source=("https://github.com/mcgillij/amdfan/releases/download/$pkgver/amdfan-$pkgver.tar.gz")
md5sums=('387643f8d342c6abd5c9d67d8f9d3687')
md5sums=('cb938f4c09db0d437e3991402f429114')

build() {
cd "$srcdir/$pkgname-$pkgver"
Expand Down
7 changes: 5 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
include = [ "LICENSE", ]

[tool.poetry.dependencies]
python = "^3.8 || ^3.9 || ^3.10"
python = "^3.9 || ^3.10"
numpy = "^1.24.1"
pyyaml = "^6.0"
click = "^8.1.3"
Expand Down
5 changes: 3 additions & 2 deletions src/amdfan/amdfan.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
import re
import sys
import time
from typing import List, Dict, Callable
from typing import Any, List, Dict, Callable
import yaml
import numpy as np
from numpy import ndarray
import click

from rich.console import Console
Expand Down Expand Up @@ -292,7 +293,7 @@ def __init__(self, points: list) -> None:
if np.min(self.speeds) <= 3:
raise ValueError("Lowest speed value to be set to 4") # Driver BUG

def get_speed(self, temp: int) -> int:
def get_speed(self, temp: int) -> ndarray[Any, Any]:
"""
returns a speed for a given temperature
:param temp: int
Expand Down

0 comments on commit 392bb18

Please sign in to comment.