Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Elevator config #45

Merged
merged 2 commits into from
Nov 25, 2024
Merged

update: Elevator config #45

merged 2 commits into from
Nov 25, 2024

Conversation

cmaddox5
Copy link
Contributor

There was one thing I missed in the design and another that was changed.

  • Screens will not be required to have accessible path images. If the image is nil, we will limit the layout to one page.
  • There is a pulsating marker on the maps to indicate where the rider is currently located. My idea is this component will be positioned absolutely and we can configure the coordinates it should be displayed at. Essentially, x maps to top and y maps to left.

@cmaddox5 cmaddox5 requested a review from a team as a code owner November 22, 2024 18:21
digitalcora
digitalcora reviewed Nov 22, 2024
View reviewed changes
lib/config/v2/elevator.ex Outdated Show resolved Hide resolved
lib/config/v2/elevator.ex Outdated Show resolved Hide resolved
@cmaddox5 cmaddox5 merged commit bbc9575 into main Nov 25, 2024
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/elevator-config-updates branch November 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalcora digitalcora digitalcora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @digitalcora