chore: Fix vendors #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
reviewed
Oct 8, 2024
digitalcora
approved these changes
Oct 8, 2024
| @@ -122,14 +123,20 @@ defmodule ScreensConfig.Screen do | |||
| |> String.ends_with?(@v2_app_id_suffix) | |||
| end | |||
|
|
|||
| for vendor <- ~w[gds mercury solari mimo c3ms outfront]a do | |||
| defp value_from_json("vendor", vendor_string, _app_id) when vendor_string in ["n/a", ""], | |||
| do: nil | |||
There was a problem hiding this comment.
We probably want to include nil as a possible input here so the null that is ultimately saved to the configuration can round-trip successfully:
defp value_from_json("vendor", vendor, _app_id) when vendor in [nil, "", "n/a"], do: nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of vendors we converted to atoms and the list of allowed vendors were out of sync. I simplified the
from_jsonlogic so it just converts the vendor into an atom. Any existing vendors set ton/aor empty strings will map to:n_a. All other unknown vendors will fail and we can fix as needed.