-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add audio config to Sectionals. #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if this is technically required — afaict the existing v1 Solari config structure does not include any of this customizability, and it seems like most of it would only be meaningful in a context where audio readouts are constantly happening on an interval, rather than on-demand as we have with these screens.
As of right now, it is required to get through this function. This sort of gets at something I mentioned in the last eng meeting where outside of the three fields called in that function, most of the struct is specific to bus shelter. What we should do is have two separate structs for push button and auto-readout screens. I can tackle that, but I'll make it a separate change. |
Hm, yes, I think we should consider separately (maybe as a group in breakdown) changing how audio is configured so we don't need to set fields that ultimately do nothing. I guess my main concern would be: After merging this, will the default values for |
I see what you're saying. So maybe instead of this, Pre Fare, and GL E-Ink having an Just realized I may have jumped ahead a step in my thought process. To answer your question, yes it would be a two step process right now: deploy the change and then update each config with a start/stop time and day of week list. |
That seems reasonable. But also not strictly necessary to sort out as part of this. I'd just want to know if we'd need further manual config changes from here to get Sectional audio to work, once it's implemented in the code. (Pre-Fares seem to use a single "standard" audio config that is not equal to |
b6d3374
to
6fd1a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔈 ✅
With this change, we will be able to validate and save the config in place in the admin tool. That will apply the default json we want. |
This PR adds the
Audio
config to Sectionals. This will be used by screens to determine if the screen should play audio.