chore: Remove AWS Cert hash check #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Is this check useful?
I'm not entirely convinced it is; it seems some other teams have already dropped it. The scenarios it would protect against are fairly esoteric, and I haven't found any recommendation from AWS itself that users of the bundle should be doing this check.
|
If we are ok removing it, happy to tackle that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash is outdated. Got the new one using
curl https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem | shasum -a 256.Is this check useful? It being outdated results in deployment errors and we end up needing to blindly follow whatever the
curlcommand returns anyway.