Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update PR Template #558

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: Update PR Template #558

merged 2 commits into from
Nov 15, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Nov 8, 2024

Added a checklist item to PR template.

@cmaddox5 cmaddox5 requested a review from a team as a code owner November 8, 2024 20:56
digitalcora
digitalcora approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good reminder — I'd maybe clarify that this only applies when this PR implements a feature with a design/UX component, though it may seem obvious.

@cmaddox5 cmaddox5 merged commit 61e5d37 into main Nov 15, 2024
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/update-pr-template branch November 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalcora digitalcora digitalcora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @digitalcora