Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New routing for Permanent Config #236

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

PaulJKim
Copy link
Contributor

@PaulJKim PaulJKim commented Nov 9, 2023

Asana task: [Perm config] Create new app routing

Adds new frontend routes and sidebar items for the "Pending" and "Configure" pages. Also adds a minor backend change to support the routing/urls.

@@ -30,6 +33,8 @@ class AppRoutes extends React.Component {
<Route path="dashboard" element={<PlacesPage />}></Route>
<Route path="alerts" element={<AlertsPage />}></Route>
<Route path="alerts/:id" element={<AlertDetails />}></Route>
<Route path="pending" element={<PendingScreensPage />}></Route>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new component with just a header for the pending page. I believe the configure screens page can be inserted with this PR

@PaulJKim PaulJKim requested review from a team and jzimbel-mbta and removed request for a team November 9, 2023 21:24
Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulJKim PaulJKim merged commit 0eead6c into master Nov 13, 2023
4 checks passed
@PaulJKim PaulJKim deleted the pk/perm-config-new-routing branch November 13, 2023 17:50
cmaddox5 added a commit that referenced this pull request Dec 13, 2023
cmaddox5 added a commit that referenced this pull request Dec 13, 2023
* Revert "[WIP] POC for using ETag to verify screens config version (#234)"

This reverts commit 8d787e0.

* Revert "New routing for Permanent Config (#236)"

This reverts commit 0eead6c.

* Revert "Stub out permanent config operations (#232)"

This reverts commit b502c0e.
cmaddox5 pushed a commit that referenced this pull request Dec 13, 2023
* Add new frontend routes and sidebar options

* Add backend routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants