credo

mbta · Nov 8, 2023 · b917e01 · b917e01
1 parent 38802d6
commit b917e01
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/screenplay/config/config.ex b/lib/screenplay/config/config.ex
@@ -32,12 +32,14 @@ defmodule Screenplay.Config.PermanentConfig do
   end
 
   defp get_current_config(etag) do
-    with {:ok, config, current_etag} <- S3Fetch.get_screens_config() do
-      if etag == current_etag,
-        do: {:ok, config},
-        else: :error
-    else
-      _ -> :error
+    case S3Fetch.get_screens_config() do
+      {:ok, config, current_etag} ->
+        if etag == current_etag,
+          do: {:ok, config},
+          else: :error
+
+      _ ->
+        :error
     end
   end
 end
diff --git a/lib/screenplay/config/s3_fetch.ex b/lib/screenplay/config/s3_fetch.ex
@@ -18,7 +18,7 @@ defmodule Screenplay.Config.S3Fetch do
     end
   end
 
-  def get_screens_config() do
+  def get_screens_config do
     with {:ok, screens_contents, etag} <- do_get(:screens),
          {:ok, screens_json} <- Jason.decode(screens_contents) do
       {:ok, screens_json, etag}