Change time to display "BRD" to <60 seconds until departure at termin…

…als (#861)

lib/content/message/predictions.ex

@@ -39,7 +39,7 @@ defmodule Content.Message.Predictions do
 
     {minutes, approximate?} =
       cond do
-        prediction.stopped_at_predicted_stop? and (!terminal? or sec <= 30) -> {:boarding, false}
+        prediction.stopped_at_predicted_stop? and (!terminal? or sec <= 60) -> {:boarding, false}
         !terminal? and sec <= 30 -> {:arriving, false}
         !terminal? and sec <= 60 -> {:approaching, false}
         min > 60 -> {60, true}

test/content/messages/predictions_test.exs

@@ -215,9 +215,24 @@ defmodule Content.Message.PredictionsTest do
       assert Content.Message.to_string(msg) == "Ashmont        BRD"
     end
 
-    test "does not put boarding on the sign too early when train is stopped at terminal" do
+    test "put boarding on the sign when train is stopped at terminal and departing in less than 60 seconds" do
       prediction = %Predictions.Prediction{
-        seconds_until_departure: 35,
+        seconds_until_departure: 59,
+        direction_id: 1,
+        route_id: "Mattapan",
+        destination_stop_id: "70261",
+        stopped_at_predicted_stop?: true,
+        boarding_status: "Stopped at station"
+      }
+
+      msg = Content.Message.Predictions.new(prediction, true, nil)
+
+      assert Content.Message.to_string(msg) == "Ashmont        BRD"
+    end
+
+    test "puts 1 min on sign when train is stopped at terminal but departure is between 60-90 seconds" do
+      prediction = %Predictions.Prediction{
+        seconds_until_departure: 61,
         direction_id: 1,
         route_id: "Mattapan",
         destination_stop_id: "70261",
@@ -230,6 +245,21 @@ defmodule Content.Message.PredictionsTest do
       assert Content.Message.to_string(msg) == "Ashmont      1 min"
     end
 
+    test "puts minutes on sign when train is stopped at terminal but departure is >=1.5 minutes" do
+      prediction = %Predictions.Prediction{
+        seconds_until_departure: 92,
+        direction_id: 1,
+        route_id: "Mattapan",
+        destination_stop_id: "70261",
+        stopped_at_predicted_stop?: true,
+        boarding_status: "Stopped at station"
+      }
+
+      msg = Content.Message.Predictions.new(prediction, true, nil)
+
+      assert Content.Message.to_string(msg) == "Ashmont      2 min"
+    end
+
     test "puts 1 min on the sign when train is not boarding, but is predicted to depart in less than a minute when offset" do
       prediction = %Predictions.Prediction{
         seconds_until_departure: 70,

test/signs/realtime_test.exs

@@ -497,6 +497,48 @@ defmodule Signs.RealtimeTest do
       Signs.Realtime.handle_info(:run_loop, @terminal_sign)
     end
 
+    test "When the train is stopped at the terminal and departing in <= 60 seconds, shows BRD" do
+      expect(Engine.Predictions.Mock, :for_stop, fn _, _ ->
+        [
+          prediction(
+            destination: :mattapan,
+            stopped: 0,
+            seconds_until_arrival: -1,
+            seconds_until_departure: 60,
+            trip_id: "3"
+          )
+        ]
+      end)
+
+      expect_messages({"Mattapan       BRD", ""})
+
+      expect_audios(
+        [
+          {:canned, {"109", ["501", "21000", "4100", "21000", "864", "21000", "544"], :audio}}
+        ],
+        [{"The next Mattapan train is now boarding.", nil}]
+      )
+
+      Signs.Realtime.handle_info(:run_loop, @terminal_sign)
+    end
+
+    test "When the train is stopped at the terminal and departing in more than 60 seconds, shows mins to departure" do
+      expect(Engine.Predictions.Mock, :for_stop, fn _, _ ->
+        [
+          prediction(
+            destination: :mattapan,
+            stopped: 0,
+            seconds_until_arrival: nil,
+            seconds_until_departure: 91,
+            trip_id: "3"
+          )
+        ]
+      end)
+
+      expect_messages({"Mattapan     2 min", ""})
+      Signs.Realtime.handle_info(:run_loop, @terminal_sign)
+    end
+
     test "When the train is stopped a long time away, shows max time instead of stopped" do
       expect(Engine.Predictions.Mock, :for_stop, fn _, _ ->
         [prediction(destination: :mattapan, arrival: 3700, stopped: 8)]