fix: Fix issue with non-CR routes showing up in nearby transit for stops that also serve distant CR

[EmmaSimon]

Summary

Ticket: Nearby transit shows non-CR routes between 0.5 and 1 mile away

We separately fetch CR stops with a 1 mile radius, and any other stops with a 0.5 mile radius, but we were also returning all sibling stops of any mode when a stop was in range. This was leading to subway routes being bubbled to the top, even though they were only served at more distant commuter rail stops. This change only returns sibling stops of commuter rail if those siblings are also commuter rail.

⚠️ We had initially implemented this behavior on purpose, we thought that it would be weird to show a CR station at all without also showing the other routes that that station served. It seems like we've decided that we don't actually want that, but we should check in with design.

This was initially done on the frontend in mbta/mobile_app#126

Testing

Fix breaking tests, the existing base integration test already had a case where (shuttle) bus stops were being included, now the test checks explicitly that they're excluded.

[github-actions]

Coverage of commit 3d6314f

Summary coverage rate:
  lines......: 73.8% (815 of 1104 lines)
  functions..: 70.9% (388 of 547 functions)
  branches...: no data found

Files changed coverage rate:
                                                               |Lines       |Functions  |Branches    
  Filename                                                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================================================
  lib/mbta_v3_api/stop.ex                                      |97.2%     36|92.9%    14|    -      0
  lib/mobile_app_backend_web/controllers/nearby_controller.ex  | 100%     21|90.0%    10|    -      0
  test/support/factory.ex                                      |80.0%     10|55.0%    20|    -      0

Download coverage report

[github-actions]

Coverage of commit 5f03f69

Summary coverage rate:
  lines......: 73.8% (815 of 1104 lines)
  functions..: 70.9% (388 of 547 functions)
  branches...: no data found

Files changed coverage rate:
                                                               |Lines       |Functions  |Branches    
  Filename                                                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================================================
  lib/mbta_v3_api/stop.ex                                      |97.2%     36|92.9%    14|    -      0
  lib/mobile_app_backend_web/controllers/nearby_controller.ex  | 100%     21|90.0%    10|    -      0
  lib/open_trip_planner_client/nearby.ex                       |63.6%     22|71.4%     7|    -      0
  test/support/factory.ex                                      |80.0%     10|55.0%    20|    -      0

Download coverage report

[github-actions]

Coverage of commit 3394fdb

Summary coverage rate:
  lines......: 73.8% (815 of 1104 lines)
  functions..: 70.9% (388 of 547 functions)
  branches...: no data found

Files changed coverage rate:
                                                               |Lines       |Functions  |Branches    
  Filename                                                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================================================
  lib/mbta_v3_api/stop.ex                                      |97.2%     36|92.9%    14|    -      0
  lib/mobile_app_backend_web/controllers/nearby_controller.ex  | 100%     21|90.0%    10|    -      0
  lib/open_trip_planner_client/nearby.ex                       |63.6%     22|71.4%     7|    -      0
  test/support/factory.ex                                      |80.0%     10|55.0%    20|    -      0

Download coverage report