refactor: move analytics abstractions to shared #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Jan 16, 2025
| /** | ||
| * Swift requires forwards compatibility for the SwiftUI ColorScheme enum; presumably Apple is | ||
| * planning to implement an [Aing-Tii](https://starwars.fandom.com/wiki/Aing-Tii/Legends) color | ||
| * scheme in iOS 50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: GA for Android
This will let us be confident we're using consistent parameter names between iOS and Android.
I've jumped through a few hoops to preserve the
class_nameparameter for existing analytics events, but coming up with a value to use there for newly created events may not be straightforward, and we should probably pull these out into constants if they are in fact load-bearing; I'll ask at standup if these are important.iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Checked that all the code still compiles and logs that it's not sending events due to running in debug mode at the times I'd expect it to try to send events. Updated the one existing unit test that touches analytics to pass with the new setup.